Allow use of vcpkg for handling local dependencies #3950
Conversation
|
This pull request has been linked to Shortcut Story #26199: Allow using vcpkg locally for all dependencies. |
davisp
force-pushed
the
pd/sc-26199/local-vcpkg-for-deps
branch
from
8d3e80e
to
7de0fd1
Compare
| @@ -34,6 +34,7 @@ Configuration: | |||
| --help print this message | |||
| --prefix=PREFIX install files in tree rooted at PREFIX | |||
| ['"${default_prefix}"'] | |||
| --enable-vcpkg use vcpkg for downloading and building dependnecies | |||
There was a problem hiding this comment.
bootstrap.ps1 also needs to be updated.
There was a problem hiding this comment.
I don't have any way to test changes here so I didn't bother attempting to write something that might or might not work. I was hoping one of our Windows dev folks would be able to add the option after this PR is merged.
There was a problem hiding this comment.
I'll preface this with a heavy "I have no idea what I'm talking about" disclaimer, but another thing that caught my eye in the vcpkg docs was that they seemed to focus on IDEs when talking about configuring Windows projects. I still think we should add a bootstrap.ps1 option for symmetry, but I wasn't sure if it'd actually be used or if there'd be some other set of instructions for configuring IDEs.
There was a problem hiding this comment.
dependnecies -> dependeNcies next time someone touches this
davisp
force-pushed
the
pd/sc-26199/local-vcpkg-for-deps
branch
3 times, most recently
from
c686c06
to
c50965a
Compare
davisp
force-pushed
the
pd/sc-26199/local-vcpkg-for-deps
branch
from
c50965a
to
3582c17
Compare
This adds a `--enable-vcpkg` configuration flag to CMake that allows developers to build all dependencies with vcpkg.
davisp
force-pushed
the
pd/sc-26199/local-vcpkg-for-deps
branch
from
3582c17
to
c562d9f
Compare
| @@ -34,6 +34,7 @@ Configuration: | |||
| --help print this message | |||
| --prefix=PREFIX install files in tree rooted at PREFIX | |||
| ['"${default_prefix}"'] | |||
| --enable-vcpkg use vcpkg for downloading and building dependnecies | |||
There was a problem hiding this comment.
dependnecies -> dependeNcies next time someone touches this
They were introduced in TileDB-Inc#3950 (which says it just copied them from upstream vcpkg) and have not been modified since.
They were introduced in TileDB-Inc#3950 (which says it just copied them from upstream vcpkg) and have not been modified since.
They were introduced in TileDB-Inc#3950 (which says it just copied them from upstream vcpkg) and have not been modified since.
They were introduced in TileDB-Inc#3950 (which says it just copied them from upstream vcpkg) and have not been modified since.
This adds a
--enable-vcpkgflag to bootstrap which allows using vcpkg to build all dependencies.I highly recommend reviewing this PR one commit at a time as the commit that adds all the port definitions is rather large and just copied from upstream vcpkg's registry.
TYPE: IMPROVEMENT
DESC: Allow use of vcpkg for installing dependencies locally