Don't use non empty domain on empty array. #4719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced in #4710. In that PR, we could try to use the non empty domain of an array with no fragments, which is empty. This should fix python and R nightlies. --- TYPE: NO_HISTORY DESC: Don't use non empty domain on empty array.
This was referenced Feb 10, 2024
What was tickled was actually just 'plain master' of the R package against 'plain dev' of Core, which is what the nighly job does. But we also saw it outside the nightlies. This appears to fix it so 👍 |
eddelbuettel
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in #4710. In that PR, we could try to use the non empty domain of an array with no fragments, which is empty. This should fix python and R nightlies.
TYPE: NO_HISTORY
DESC: Don't use non empty domain on empty array.