Remove all deprecated APIs. #5146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
force-pushed
the
teo/remove-deprecated
branch
from
8f912be
to
235da5f
Compare
… and timestamp. There are already overloads with just query type, query type and key, and query type, key and timestamp. This will fill the Cartesian product.
teo-tsirpanis
force-pushed
the
teo/remove-deprecated
branch
4 times, most recently
from
c0a75e1
to
eab787a
Compare
teo-tsirpanis
force-pushed
the
teo/remove-deprecated
branch
from
eab787a
to
aaa5517
Compare
teo-tsirpanis
force-pushed
the
teo/remove-deprecated
branch
from
b9f7134
to
54cdc69
Compare
|
REST-CI is green. |
KiterLuc
approved these changes
Jul 16, 2024
|
REST CI is passing and all the internal dependencies have been built with TILEDB_REMOVE_DEPRECATIONS to make sure they are not using deprecated APIs. |
This was referenced Jul 17, 2024
eric-hughes-tiledb
added a commit
that referenced
this pull request
Jul 17, 2024
With the removal of deprecated function in #5146, the opportunity arises to remove asynchronous query submission, which the C API no longer has any reference to. Alongside this, there is other dead code in `StorageManager` in need of pruning. This PR simplifies its constructor a bit and removes unused members variables.
eric-hughes-tiledb
added a commit
that referenced
this pull request
Jul 18, 2024
With the removal of deprecated function in #5146, the opportunity arises to remove asynchronous query submission, which the C API no longer has any reference to. Alongside this, there is other dead code in `StorageManager` in need of pruning. This PR simplifies its constructor a bit and removes unused members variables.
KiterLuc
pushed a commit
that referenced
this pull request
Jul 18, 2024
With the removal of deprecated function in #5146, the opportunity arises to remove asynchronous query submission, which the C API no longer has any reference to. Alongside this, there is other dead code in `StorageManager` in need of pruning. This PR simplifies its constructor a bit and removes unused members variables. [SC-50038] --- TYPE: NO_HISTORY DESC: Remove dead code in `StorageManager` and `Query`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-50038
Consistent with the announcement made in 2.23.0's release notes, this PR removes all deprecated C and C++ APIs. The infrastructure supporting the
TILEDB_REMOVE_DEPRECATIONSCMake option was kept, in case we want to deprecate another API in the future.TYPE: BREAKING_API
DESC: All deprecated C and C++ APIs were removed.