Remove Array::get_max_buffer_sizes.
#5292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rest PR at: https://github.com/TileDB-Inc/TileDB-Cloud-REST/pull/4852 |
robertbindar
force-pushed
the
rbin/ch54658/remove_maxbuffersizes
branch
from
c857b28
to
f8c6a2e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
teo-tsirpanis
force-pushed
the
rbin/ch54658/remove_maxbuffersizes
branch
2 times, most recently
from
021cf66
to
beaf5b1
Compare
teo-tsirpanis
changed the title
Array::get_max_buffer_sizes.
teo-tsirpanis
force-pushed
the
rbin/ch54658/remove_maxbuffersizes
branch
from
beaf5b1
to
0658a54
Compare
teo-tsirpanis
requested review from
shaunrd0
and removed request for
KiterLuc
shaunrd0
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Just removed an old unit test, will merge after TileDB-Inc/TileDB-Go#349 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all the code associated with
Array::get_max_buffer_sizes.This means Array bookkeeping members, functions for calculating maximum buffer sizes based on a subarray, capnp struct, rest client functions.
The
tiledb_serialize_array_max_buffer_sizesC API was kept until downstreams migrate, but its implementation was updated to always fail.Soon will follow a PR in the REST server for removing the handling code of this request.
TYPE: NO_HISTORY