Use CZI default parameters for X/obs/var #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #17557: Adopt czi default layout options. |
aaronwolen
force-pushed
the
aaronwolen/sc-17557/adopt-czi-default-layout-options
branch
3 times, most recently
from
1d76435
to
c86d455
Compare
So they can be used by child classes that overwrite provide their own creation/ingestion methods
aaronwolen
force-pushed
the
aaronwolen/sc-17557/adopt-czi-default-layout-options
branch
from
c86d455
to
92ed0e6
Compare
|
CC @dnadave @kaitlin-procogia @augustine-procogia Unfortunately I can't add you as reviewers b/c you're outside of our organization. But I'll be sure to CC you from here on out and please feel free to leave comments and give a 👍 / 👎 . |
eddelbuettel
approved these changes
May 13, 2022
|
(My DNS is sometimes wonky between my desktop/server and the access point and the browser gets a hickup. Hence to accidental double approval.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates several tiledb parameters for the storage of
obs,var, andXarrays (as discussed in #48). Also includes a few minor (internal) changes described below.Changes to
Xarrays:Changes to annotation dataframes:
obscapacity is 256varcapacity is 2048Benchmarks
I compared the ingestion times and on-disk sizes with (
tiledbsc0.1.0.9009) and without (tiledbsc0.1.0.9007) the above parameter changes for several different Seurat datasets provided by the SeuratData package.Here are the sizes of the original
.rdsfilesIngestion times:
On-disk size:
File-specific on-disk sizes:
Other changes
log_array_ingestion()