Skip to content

Conversation

Austinate
Copy link
Contributor

@Austinate Austinate commented Oct 22, 2017

Hi, this PR removes usage of UIApplication`s sharedApplication method to make library usable in extensions targets. (described in #5)

I've run tests and did manual testing for all this cases so nothing should be broken:

  • Presenting and dismissing the view controller in both portrait and landscape modes.
  • Presenting the view controller, rotating the device and then dismissing from the new orientation.
  • Presenting the view controller, then enabling split-screen on an iPad.
  • Changing the split-screen window sizes on iPad.

@Austinate
Copy link
Contributor Author

hm, looks like Travis fail is not actually related to PR changes :(

@TimOliver TimOliver merged commit 0193b64 into TimOliver:master Nov 16, 2017
@TimOliver
Copy link
Owner

Sorry for the delay! Yeah, I think Travis was complaining because of a wrong Xcode version.

Thanks for that! That looks good! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants