-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attacking Towers #33
Attacking Towers #33
Conversation
950b06a
to
904d59f
Compare
rebased on top of your latest code |
Added a static method to break-apart the full unit-list provided in protobuffer into unit-type lists in a single pass so that unit_matrix() static method doesn't have to iterate the full list numerous times as for-loops in python tend to be not the most efficient. |
Since we now use zero-sum game and enemy rewards are reflected inversely in our rewards I fixed tower health reward to not be a zero-sum game in itself as we were thus doubling the effect. Also, I believe I had the reward value reversed by accident. |
Added a parameter for tracking whether a unit "is attacking me" (normalized to [-0.5 to 0.5]) and removed the facing_sin and facing_cos parameters as they do not affect any of the actions we have enabled thus far (if we attack, it will just turn and attack...) If we bring them back in the future we should quantize them better as they add a lot of state-space search the way they were implemented. |
Apparently I always have access to all the buildings/towers of allied & enemies in the unit-list protobuf. Data might not be valid but they are present so I added a way to filter them out. |
I got some trouble ingesting this. Let me know when you clean it up/RFR |
Sure, what is the ingest trouble? Sorry I don't understand if you mean "merging" or "understanding" or ??? |
Code is doing quite a lot, not simple to review
…On Mon, Feb 4, 2019, 12:39 Nostrademous ***@***.*** wrote:
Sure, what is the ingest trouble? Sorry I don't understand if you mean
"merging" or "understanding" or ???
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHXSRJGe3ss_RIr359XjOCAWLdIP2AZ6ks5vKJpzgaJpZM4afJD2>
.
|
Okay, added a few more comments but it still will be a lot I fear. Here is what the code does:
|
btw did you rebase? |
I did 23 hrs ago and you haven’t made any committed since so it is sitting on top of your HEAD |
Well... I'm going to have to rebase again and do some merge conflict clean up. Probably in 1-2 hrs when I have time. |
… remove micro-location-reward
…f 1_mid tower if above 10% health
7823640
to
c7092d7
Compare
@TimZaman Okay, rebased on your latest commits. Hopefully I have explained it enough. |
Hmm so 90% is great, 5% is up for discussion and 5% i disagree with. I think I'll merge it and then patch up. Or just patch up the MR directly. I guess I'll do that. |
This is a start to improve #32
We can now attack towers.
This also compares tower health between the friendly and enemy mid tier 1 tower as a reward.
Also adds more reward to a win/loss.
Minor fixes here and there.