Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-bazel & bazel file query error #9

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

tinder-maxwellelliott
Copy link
Collaborator

@tinder-maxwellelliott tinder-maxwellelliott commented Sep 25, 2020

When we mix files that are tracked by Bazel with files that are not tracked by Bazel, bazel query fails. Even with --keep-going enabled we are getting a non zero exit code and that is preventing us from reading from our output proto stream.

This stopgap solution should be fine for now. We need to find a way to get back to our optimized query

Fixes #8

@tinder-maxwellelliott tinder-maxwellelliott merged commit 5d4bf34 into master Sep 25, 2020
@tinder-maxwellelliott tinder-maxwellelliott deleted the fix_silent_non_bazel_file_failure branch September 25, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaks when non-bazel files are included in modified paths
1 participant