Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix omm #8

Merged
merged 3 commits into from
Jul 7, 2015
Merged

Fix omm #8

merged 3 commits into from
Jul 7, 2015

Conversation

swails
Copy link
Collaborator

@swails swails commented Jun 18, 2015

This fixes a number of issues with the OpenMM integration:

  • Makes sure unit cell vectors are set correctly for non-orthogonal cells
  • Resolves a bunch of compiler warnings associated with structs that had no external linkage (fixed by making them static)
  • Resolves more compiler warnings about assigning to char* via = (you can do this with std::string, but not char*)
  • Adds the functionality to write out a system.xml file that can be used with OpenMM in standalone mode if you request 0 steps with dynamic_omm.

@swails
Copy link
Collaborator Author

swails commented Jun 24, 2015

@jayponder -- I submitted this PR to go directly into your master branch. It only touches the OpenMM stuff, though, and fixes things so it works correctly with triclinic cells. I can resubmit the PR to go to a different branch if you want me to, but I can't see a reason why this shouldn't go into master, personally. (I just don't want to screw up anything you might be working on).

Let me know if I'm good to merge this to master.

Thanks!

@swails
Copy link
Collaborator Author

swails commented Jul 7, 2015

I'm going to go ahead and merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant