Skip to content

HorariumLogger does not output actual exception #23

Closed
Tolyandre opened this issue Jun 19, 2019 · 1 comment · Fixed by #26
Closed

HorariumLogger does not output actual exception #23

Tolyandre opened this issue Jun 19, 2019 · 1 comment · Fixed by #26
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Tolyandre
Copy link
Contributor

Tolyandre commented Jun 19, 2019 •
edited
Loading

When using Horarium.AspNetCore errors are logged without actual exception.
image

It seems that HorariumLogger.cs puts params in wrong order:
_logger.LogError(message, ex);

Expected:
_logger.LogError(ex, message);
@Bounz
Copy link
Contributor

Bounz commented Jun 20, 2019 •
edited
Loading

It would be nice if you could provide a PR with a fix for this issue.

@Bounz Bounz added good first issue Good for newcomers bug Something isn't working labels Jun 20, 2019
@Bounz Bounz mentioned this issue Jul 4, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pass exception to LogError() Tinkoff/Horarium
2 participants
@Tolyandre @Bounz