Skip to content

fix: pass exception to LogError() #26

Merged
merged 1 commit into from
Jul 4, 2019
Merged

fix: pass exception to LogError() #26

merged 1 commit into from
Jul 4, 2019

Conversation

Bounz
Copy link
Contributor

@Bounz Bounz commented Jul 4, 2019

This fixes #23

@codecov-io
Copy link

codecov-io commented Jul 4, 2019

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   57.93%   57.93%           
=======================================
  Files          29       29           
  Lines         813      813           
=======================================
  Hits          471      471           
  Misses        342      342
Impacted Files Coverage Δ
src/Horarium.AspNetCore/HorariumLogger.cs 25% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed25289...8b014fa. Read the comment docs.

@Bounz Bounz requested a review from Bobreshovr July 4, 2019 07:14
@Bobreshovr Bobreshovr merged commit 566d99e into master Jul 4, 2019
Copy link
Contributor

@Tolyandre Tolyandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change this for Debug() too?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HorariumLogger does not output actual exception
4 participants