Respect host's ShutdownTimeout (e.g. cancellation token) when stopping jobs #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
==========================================
+ Coverage 69.39% 69.85% +0.46%
==========================================
Files 32 32
Lines 905 909 +4
==========================================
+ Hits 628 635 +7
+ Misses 277 274 -3
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We made a graceful stopping in #41. This PR adds respect to ShutdownTimeout by using a cancellation token from
IHostedService.StopAsync(). Thus Horarium will abandon awaiting jobs after the timeout. This way feels consistent with .Net core.