Feature 7 #9
Feature 7 #9
Conversation
README.md
Outdated
| @@ -9,12 +9,21 @@ Horarium is fully based on an asynchronous work model, it allows you to run hund | |||
|
|
|||
| Horarium supports .NET Core/netstandard 2.0 and .NET Framework 4.6.2 and later. | |||
|
|
|||
| Support Database | |||
src/Horarium.Mongo/JobMongoModel.cs
Outdated
|
|
||
| namespace Horarium.Mongo | ||
| { | ||
| [MongoEntity("scheduler.jobs")] |
There was a problem hiding this comment.
Maybe we should name this collection horarium.jobs (and collection for recurrent jobs too)?
There was a problem hiding this comment.
what about horarium.jobs.scheduler?
There was a problem hiding this comment.
I think horarium.jobs is better
| @@ -18,14 +16,14 @@ public class TestParallelsWorkTwoManagers : IntegrationTestBase | |||
| public TestParallelsWorkTwoManagers() | |||
| { | |||
| var provider = new MongoClientProvider(ConnectionMongo); | |||
| var collection = provider.GetCollection<JobDb>(); | |||
| var collection = provider.GetCollection<JobMongoModel>(); | |||
There was a problem hiding this comment.
Why integration test is stuck to Mongo DB provider?
Maybe we should rename the tests to reflect that these tests are for MongoDB?
Will be there same integration tests for other DB providers?
There was a problem hiding this comment.
I should exist this test for all providers, I will add TestCase
src/Horarium.Mongo/JobMongoModel.cs
Outdated
| ExecutedMachine = ExecutedMachine, | ||
| StartAt = StartAt, | ||
| NextJob = | ||
| NextJob?.ToJobDb(), |
src/Horarium.Mongo/JobMongoModel.cs
Outdated
| }; | ||
| } | ||
|
|
||
| [BsonId] public string JobId { get; set; } |
There was a problem hiding this comment.
Maybe place attribute on a new line?
README.md
Outdated
| | Database | Support | | ||
| | ---------- | ------------------------------------------------------------------ | | ||
| | MongoDB | Yes | | ||
| | In Memory | No [#5](https://github.com/TinkoffCreditSystems/Horarium/issues/5) | |
There was a problem hiding this comment.
Let's write Not yet instead of No 🙂 .
| <Version>1.0.0$(VersionSuffix)</Version> | ||
| <Title>Horarium.Mongo</Title> | ||
| <Authors>bobreshovr</Authors> | ||
| <PackageDescription>Horarium.Mongo is the .Net library for support MongoDB in Horarium</PackageDescription> |
There was a problem hiding this comment.
Horarium.Mongo is the .Net library for support MongoDB in Horarium
May be?
to support
or
for supporting
| @@ -30,6 +31,6 @@ public interface IHorarium: IDisposable | |||
| /// <typeparam name="TJob">Type of job, job will create from factory</typeparam> | |||
| /// <returns></returns> | |||
| IRecurrentJobBuilder CreateRecurrent<TJob>(string cron) where TJob : IJobRecurrent; | |||
|
|
|||
| } | |||
| } | |||
There was a problem hiding this comment.
no newline at end of file
Fix naming and format
No description provided.