Skip to content

Removed .valueOrAbort #19

Merged
merged 1 commit into from
Aug 13, 2022
Merged

Removed .valueOrAbort #19

merged 1 commit into from
Aug 13, 2022

Conversation

InversionSpaces
Copy link
Contributor

@InversionSpaces InversionSpaces commented Aug 7, 2022 •
edited
Loading

Problem

FromExpr[QueryMeta[T]] should not abort compilation if meta could not be retrieved from expression.

Solution

Replace .valueOrAbort with .map.

@oolong/maintainers

@desavitsky
Copy link
Contributor

desavitsky commented Aug 11, 2022 •
edited
Loading

The idea was to abort compilation if there is a runtime constant in query meta.
However, when I now tried to stop compilation by using runtime constant in meta, it didn't and just ignored meta - that is to be fixed
So, I think it doesn't affect anything and can be merged
And not aborting compilation when runtime value should be fixed

@danslapman danslapman merged commit 0533a49 into main Aug 13, 2022
@danslapman danslapman deleted the feature/remove-abort branch August 13, 2022 11:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danslapman danslapman danslapman approved these changes

@desavitsky desavitsky desavitsky approved these changes

@edubrovski edubrovski Awaiting requested review from edubrovski

@Assassin4791 Assassin4791 Awaiting requested review from Assassin4791

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@InversionSpaces @desavitsky @danslapman