Extend find* utilities passed arguments to callback. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to spec Array.prototype.find and Array.prototype.findIndex passes three arguments to callback function: element, index and array. Extend current implementation according to spec. Resolves: #15
| @@ -16,7 +16,7 @@ import curryN from '../function/curryN'; | |||
| */ | |||
| export default curryN(2, (fn, arr = []) => { | |||
| for (let i = 0; i < arr.length; i++) { | |||
There was a problem hiding this comment.
So, should it be for
src/array/findLast.js
Outdated
| @@ -19,7 +19,7 @@ export default curry((fn, list) => { | |||
| let idx = list.length - 1; | |||
|
|
|||
| while (idx >= 0) { | |||
Replace while with for statement.
osorokotyaga
added a commit
that referenced
this pull request
Sep 21, 2018
* Extend find* utilities passed arguments to callback. According to spec Array.prototype.find and Array.prototype.findIndex passes three arguments to callback function: element, index and array. Extend current implementation according to spec. Resolves: #15 * Code style change for array/findLast. Replace while with for statement.
osorokotyaga
added a commit
that referenced
this pull request
Mar 22, 2019
* Call throttleEnd with last arguments within `wait` period (#11) Now, when a function throttled with throttleEnd is invoked several times within a wait period it is finally called by throttleEnd with arguments, provided at last! invoke. Resolves: #9 * Remove sanitize util. (#12) src/sanitize was too dumb, better use specially oriented sanitize packages Resolves: #3 * Extend find* utilities passed arguments to callback. (#16) * Extend find* utilities passed arguments to callback. According to spec Array.prototype.find and Array.prototype.findIndex passes three arguments to callback function: element, index and array. Extend current implementation according to spec. Resolves: #15 * Code style change for array/findLast. Replace while with for statement. * Feature/remove docs from master (#13) * Remove docs folder. * Add script to generate docs and publish it to gh-pages branch. Resolves: #4 * Тайпинги (#10) * fix tests * Тайпинги * add ts-jest * Перевел на typescript * Добавил в сборку компиляцию typescript и копирование при блиде * Поправил тайпинги, добавил ts-jest и @types/ramda в package.json * Вынес ramda типы в файл types.ts * move all definitions to types.ts * Memoize without types (#28) * Adds .editorconfig file * Adds editors service folders to .gitignore * Updates README.MD with support information * Adds memoization functions * Adds Map using to deepSizeLimit memoization function * Fixes test descriptions and code indendation (4 spaces) * Adds memoizeOne function (save only last result - like reselect) * Renames "shallow" to "strict" (it's more proper name for this functionality) * Omit string conversion (#27) * object/omit add test for string conversion bug * Fix object/omit props string conversion. Resolves: #22 * Remove utils/is/not in favor of utils/not Resolves: #18 * release 2.0.0-alpha * rename memoize functions to ts * Update CHANGELOG.md * Upgrade to babel@7 and remove copying .babelrc to dist package (#35) Resolves: #14 * fix bug in generating random index for array/shuffle (#34) Resolves: #25 * Increase coverage of some utilities (#36) Resolves: #26 * Fix array/maxBy edge cases (#37) Resolves: #29 * add type guards for src/is utilities (#38) Resolves: #30 * add is/shallowEqual (#39) Resolves: #31 * Add default exports (#40) * split typings to files, remove unused types * split createCacheFrom and MemoizeWith to separate files * improve modules build to prevent to generate useless code Resolves: #32 * fix docs generation (#41) enable docs generation for typescript fix missing files on gh-pages Resolves: #33 * publish 2.0.0-alpha.2 * fix typings for src/array * fix typings for src/function * fix typings for src/is * fix typings for src/object * fix typings for src/promise * fix typings for src/string * fix typings for src/ * fix typings * add typings to benchmark runner * fix typings * publish 2.0.0-alpha.3 * fix typings * publish 2.0.0-alpha.4 * fix typings * publish 2.0.0-alpha.5 * fix typings * fix build * publish 2.0.0-alpha.6 * publish 2.0.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to spec Array.prototype.find and Array.prototype.findIndex passes three arguments to callback function: element, index and array. Extend current implementation according to spec.
Resolves: #15