Error: show no random tip, because randomize did not pass is not an error
#7
Labels
bug
Something isn't working
Comments
|
Oh yes, feel free to change it. |
rugk
added a commit
that referenced
this issue
Aug 22, 2022
Fixes #7 The issue is here that a promise is usually expected, so I cannot just return Promise.ject() with an empty error, because this also results in a red error for the promise (with the worse error message "undefined"). Thus I've just made it to return a successful promise or undefined. I've also changed the similar uncritical error when tips should be shown according to gobal randomize, but no tip could be shown due to other factors, so there is no tip to be shown. Console.trace is BTW well-supported across browsers: https://developer.mozilla.org/en-US/docs/Web/API/console/trace#browser_compatibility
rugk
added a commit
that referenced
this issue
Aug 22, 2022
Fixes #7 The issue is here that a promise is usually expected, so I cannot just return Promise.ject() with an empty error, because this also results in a red error for the promise (with the worse error message "undefined"). Thus I've just made it to return a successful promise or undefined. I've also changed the similar uncritical error when tips should be shown according to gobal randomize, but no tip could be shown due to other factors, so there is no tip to be shown. Console.trace is BTW well-supported across browsers: https://developer.mozilla.org/en-US/docs/Web/API/console/trace#browser_compatibility Fixes #7
rugk
added a commit
that referenced
this issue
Aug 22, 2022
Fixes #7 The issue is here that a promise is usually expected, so I cannot just return Promise.ject() with an empty error, because this also results in a red error for the promise (with the worse error message "undefined"). Thus I've just made it to return a successful promise or undefined. I've also changed the similar uncritical error when tips should be shown according to gobal randomize, but no tip could be shown due to other factors, so there is no tip to be shown. Console.trace is BTW well-supported across browsers: https://developer.mozilla.org/en-US/docs/Web/API/console/trace#browser_compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is not an error and should not be output as one, as it makes finding actual errors in the console more difficult:
It is output nearly every time the options page or browser action popup is opened for all extensions that use this library, including the Awesome Emoji Picker.
The text was updated successfully, but these errors were encountered: