Typescript definition doesn't seem to be correct.

[dperetti]

import odiff from 'odiff'

odiff.equal()

-> Property 'equal' does not exist on type '(a: any, b: any) => odiffResult[]'

[fresheneesz]

Ah hm, would you mind testing if the following works?

import * as odiff from 'odiff'

[dperetti]

Doesn't work either.

[fresheneesz]

Sorry, I don't use typescript. @tontonrally added the code for that, so maybe he can help? Otherwise you might need to do your own investigating. I'm happy to help. I'd recommend seeing what is inside odiff in the two cases you tried up there (if 'equal' doesn't exist, is it null, is it an emtpy object, something else?)

[dperetti]

👉 #12

[fresheneesz]

👉😎👉

[fresheneesz]

Published v1.4.0 with this in it

[tontonrally]

Sorry guys, didn't see that... As it is now fixed, I don't need to dig into. Thanks @dperetti for the fix.

[chapmanjacobd]

type 'rm' has vals: any[]

[fresheneesz]

@chapmanjacobd I think you're right. Would you be willing to write a pull request for that?

[chapmanjacobd]

Ok

…

On Fri, Jun 5, 2020, 12:57 fresheneesz ***@***.***> wrote: @chapmanjacobd <https://github.com/chapmanjacobd> I think you're right. Would you be willing to write a pull request for that? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4KV2LUL5G4MDK35QGHD4DRVCCLXANCNFSM4J6NVHJA> .

[fresheneesz]

Fixed in pull request #19