-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge install into master to fix the installation of ttkwidgets #10
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=======================================
Coverage 92.85% 92.85%
=======================================
Files 42 42
Lines 2687 2687
=======================================
Hits 2495 2495
Misses 192 192 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=======================================
Coverage 93.02% 93.02%
=======================================
Files 44 44
Lines 2825 2825
=======================================
Hits 2628 2628
Misses 197 197 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just noticed that in Linux, when there is the line include_package_data=True,
the package_data is not included in the distribution archive while everything works fine if I remove this line. Does it work without it in Windows too?
Otherwise, I think it might be more consistent to include the sub-packages with
packages=["ttkwidgets", "ttkwidgets.frames", "ttkwidgets.font", "ttkwidgets.autocomplete", "ttkwidgets.color"],
instead of including them in the package data.
Finally, I don't think that the MANIFEST.in
file is needed anymore.
Yes, in that case I misunderstood what you wanted to do. You are right, your version of the |
This makes the command
setup.py install
include the folder structure, so the imports work correctly. If this is merged, I'd say it would be a good idea to publish version0.6.1
on PyPI as a non-production ready package.