Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitle features and build request, README update #141

Open
Questwalker opened this issue Feb 10, 2024 · 1 comment
Open

Subtitle features and build request, README update #141

Questwalker opened this issue Feb 10, 2024 · 1 comment

Comments

@Questwalker
Copy link

Questwalker commented Feb 10, 2024

Various things, first issue so please be kind.

Features:

Similar to the --audio-lang feature that was added, a --sub-lang should be added. Disabling certain subtitles is already possible, but this would make it easier to do it without fiddling around with files. For example, --sub-lang "en,jp" would only embed the english and japanese subtitles.

Additionally, a option to burn subtitles into the video should be added so that the videos are easier to share. FFMPEG has a feature for it here. (A note should be included in the README that using this option will cause videos to take some time to process)

New release request:

As seen in #127, A new build of the program should be released, so that people use the latest features of the program without having to build it themselves.

README

As mentioned in #63, The link to the subtitle repo seen here is dead, the repo has been moved to https://gitlab.com/Dimbreath/AnimeGameData. Update the README with this new link.

@ft-scobra
Copy link

ft-scobra commented Feb 26, 2024

Additionally, a option to burn subtitles into the video should be added so that the videos are easier to share. FFMPEG has a feature for it here. (A note should be included in the README that using this option will cause videos to take some time to process)

@Questwalker I'm working on a fork of this which focuses on these issues. Currently using batch files as its easy just drag n drop the file. It generates an mkv with all audio and subs. then rips the en sub(working on this, for now make sure only EN folder is in GenshinData) and makes an mp4 with hardsubs using ffmpeg. hard subs has the same font as mkv.

i am relatively new to coding and github so be patient with me thanks.

Also, as of writing this, I am also working on improving the batch program to give choices like which audio, subtitles, file format, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants