Unstable rotation #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e likely in an unstable landmark situation and thus should error
caught cv2.error when face_detector works, but patches are not consistent
|
Love it! Thanks a lot @ngageorange. Do you wanna show me a live demo? /cc @hjchang: please tell your student if he is still around |
Sure, anytime |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #30
Compare last frame's rvec, if rotating > 0.1rad, then error out. To avoid adding more parameters to rt_gene, I experimented a little with where the threshold is instability and it's roughly at at 0.1
Let me know what you think.