Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add Github Actions CI/CD Bot #810

Merged
merged 22 commits into from
May 5, 2023
Merged

Feat: Add Github Actions CI/CD Bot #810

merged 22 commits into from
May 5, 2023

Conversation

eakmanrq
Copy link
Contributor

@eakmanrq eakmanrq commented May 3, 2023 •
edited
Loading

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 3, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@eakmanrq eakmanrq changed the title Add Github Actions CI/CD Bot Feat: Add Github Actions CI/CD Bot May 3, 2023
@eakmanrq eakmanrq force-pushed the eakmanrq/add_github_actions_bot branch from c81dc00 to 417d87f Compare May 3, 2023 23:56
@eakmanrq eakmanrq requested a review from a team May 3, 2023 23:57
@eakmanrq
Copy link
Contributor Author

eakmanrq commented May 3, 2023

The Github CI/CD no longer requires integration into Airflow or the notification target system. So I went ahead and removed that stuff in this commit: c3f5039

I'm leaving though the concept of a notification target in the code since it can be used for Slack/Email work coming up.

tobymao
tobymao reviewed May 4, 2023
View reviewed changes
sqlmesh/cicd/bot.py Outdated Show resolved Hide resolved
@eakmanrq eakmanrq force-pushed the eakmanrq/add_github_actions_bot branch from c40cb88 to cf90a31 Compare May 5, 2023 16:10
@eakmanrq eakmanrq force-pushed the eakmanrq/add_github_actions_bot branch from 2be4762 to 33ef755 Compare May 5, 2023 16:42
@eakmanrq eakmanrq merged commit b8906dc into main May 5, 2023
@eakmanrq eakmanrq deleted the eakmanrq/add_github_actions_bot branch May 5, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izeigerman izeigerman izeigerman left review comments

@tobymao tobymao tobymao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eakmanrq @CLAassistant @izeigerman @tobymao