Fix: Improve loader overriding #819
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior behavior was as follows:
YAML < Python < Env
The issue is that when we create the config objects from the YAML definition we would validate with Pydantic that config and part of the required config could still be defined in environment variables.
The fix is to load the YAML into a dict and then apply the environment vars to that dict. After that we then create the Pydantic models. This means though that environment variables do not override what might be defined in Python models. So now the order is like this:
YAML < Env < Python
This does mean that env var overrides must be key based overrides but that already exists prior to this change.