Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lab/login] please add federation #48

Merged
merged 8 commits into from
Nov 16, 2024
Merged

[lab/login] please add federation #48

merged 8 commits into from
Nov 16, 2024

Conversation

Svenlaa
Copy link
Contributor

@Svenlaa Svenlaa commented Nov 10, 2024

i hope this code is fine

todo

  • add user-styles.css file for other instances

federates with

how?

  1. request all those URLs
  2. add the reponse objects to the entries array, including the new instance name
  3. act like everything is fine

other

  • assumes the first instance in the list in SELF instance
  • loads user-styles.css file from svenlaa.com for their styles
  • usernames get a lot longer, will break PodeTond 💚 style
  • puts instance-specific things into consts at the top of the javascript so it can easily be found when making a new instance
  • please review the code, suggest changes. i am bad at big picture stuff

Copy link
Owner

@TodePond TodePond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome stuff

just making some notes for the future... feel free to ignore or act on - up to you :)

could merge even if these aren't done but let's see

@@ -323,7 +350,7 @@ <h2 id="feed-heading">
} catch (e) {
users = [];
}
const usernames = users.map((v) => v.username);
const usernames = users.map((v) => v.username + "@" + v.instance);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay i think we should probably keep track of aliases here. each user of the home server could also be referred to by just their username

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(last one before merge!!) ✈️

@@ -318,7 +328,7 @@ input[type="checkbox"] {
font-family: "JetBrains Mono", sans-serif;
}

.at-PodeTond.💚:hover {
.at-PodeTond.💚\@todepond\.com:hover {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can fix these ones, even by hardcoding maybe

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a nit: please ignore

@tkukec
Copy link
Contributor

tkukec commented Nov 11, 2024

* usernames get a lot longer, will break `PodeTond 💚` style

The code was pretty bad anyways (and browser dependent whoch sucks so much). Feel free to remove it / roll it back to gradient only, and I'll figure out something better

@TodePond
Copy link
Owner

* usernames get a lot longer, will break `PodeTond 💚` style

The code was pretty bad anyways (and browser dependent whoch sucks so much). Feel free to remove it / roll it back to gradient only, and I'll figure out something better

it's okay should be do-able :)

@TodePond
Copy link
Owner

check out Logarithm, which seems to have done a lot of these changes! 🤯

https://tristie.org/logarithm/

- get feeds with a Promise.all()
- use logiverse.js config instead of JS `const`s
- add alt text to "gifs are not supported" gif
@TodePond
Copy link
Owner

TodePond commented Nov 11, 2024

awesome stuff, I marked as resolved the ones that I think are done :)

i think it's almost there. probably just needs replies/mentions fixing for when you @ someone on your home server without specifying host - then it should implicitly refer to the person on your home server. this is for backwards compatibility with existing logs

if i have time I'll do it but anyone else is welcome to jump in 🙏

@TodePond
Copy link
Owner

yolo

@TodePond TodePond merged commit 7c3d009 into TodePond:main Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants