-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lab/login] please add federation #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome stuff
just making some notes for the future... feel free to ignore or act on - up to you :)
could merge even if these aren't done but let's see
@@ -323,7 +350,7 @@ <h2 id="feed-heading"> | |||
} catch (e) { | |||
users = []; | |||
} | |||
const usernames = users.map((v) => v.username); | |||
const usernames = users.map((v) => v.username + "@" + v.instance); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay i think we should probably keep track of aliases here. each user of the home server could also be referred to by just their username
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(last one before merge!!)
@@ -318,7 +328,7 @@ input[type="checkbox"] { | |||
font-family: "JetBrains Mono", sans-serif; | |||
} | |||
|
|||
.at-PodeTond.💚:hover { | |||
.at-PodeTond.💚\@todepond\.com:hover { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we can fix these ones, even by hardcoding maybe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a nit: please ignore
The code was pretty bad anyways (and browser dependent whoch sucks so much). Feel free to remove it / roll it back to gradient only, and I'll figure out something better |
it's okay should be do-able :) |
check out Logarithm, which seems to have done a lot of these changes! 🤯 |
awesome stuff, I marked as resolved the ones that I think are done :) i think it's almost there. probably just needs replies/mentions fixing for when you @ someone on your home server without specifying host - then it should implicitly refer to the person on your home server. this is for backwards compatibility with existing logs if i have time I'll do it but anyone else is welcome to jump in 🙏 |
yolo |
i hope this code is fine
todo
federates with
how?
other
PodeTond 💚
styleconst
s at the top of the javascript so it can easily be found when making a new instance