Feat/delete messages upto 24 hrs

[ankitsmt211]

First draft of feature, delete messages upto 24 hrs in same channel.

• db table to keep track of messages meta data
• routine to clear older records than 24 hrs
• listener to create new records on each new message
• new package for feature
• new command "/purge-in-channel"
• resolves Delete last X messages from user for moderation #912

Additions:

• db entries also has an emergency brake to prevent spamming DB to death.
• a conditional sub routine, when approaching records limit auto deletes N no of oldest records from table to make some space for new entries.

command interface:

when there's no records:

if there's any records within selected duration:

Note: Duration is optional, if skipped it defaults to last hour.

[ankitsmt211]

Couple of things to work atm:

• do something with reason for using this command, perhaps store it somewhere.
• How long to keep message data in DB, currently anything older than 2 hrs is removed.

[Zabuzard]

Please dont forget to also update the PP.md file. We must inform users about how we store their data.

[ankitsmt211]

Please dont forget to also update the PP.md file. We must inform users about how we store their data.

Is this necessary? user_id, message_id, timestamp of actions, channel_id is already mentioned in database section.

source:

[Zabuzard]

Please dont forget to also update the PP.md file. We must inform users about how we store their data.

Is this necessary? user_id, message_id, timestamp of actions, channel_id is already mentioned in database section.

source:

Ah, good. Perhaps tweak this paragraph:

Furthermore, upon utilization of our help service, user_ids, channel_ids and timestamps are stored to track when/how many questions a user asks. The data may be stored for up to 30 days.

(added and timestamps)

[ankitsmt211]

Atm duration is optional (default is 1hr) but if provided can be entered from 1-24 as value. I was thinking perhaps a better way would be to provide choices such as 3 hrs, 6 hrs, 12 hrs and 24 hrs where 1 hr is default. This makes easier for user to enter duration altho there are already checks in place for value to be between 1-24 if i stick to current way of input.

[Zabuzard]

the log would be more useful if it also gives a suggestion how to fix the problem.

"Purge History reached limit. Either delete some rows of the table or wait for them to expire."

[ankitsmt211]

Actually i think i might have a better idea, Imagine the DB is maxed out with 7.5k messages. No more records are being saved, which means any new spam messages would be ignored and using purge-in-channel would only delete older messages which might not be the best thing . Ideally i think we should keep the messages from newest to oldest upto the "max limit".

Possible Solution:
Let's say we have a limit 7.5k, we hit a mark of 7.4k. A routine should be trigged that only clears out last 500 records or so. This way all the new messages are being tracked and command is not useless past the limit. Thoughts ?

[ankitsmt211]

@Zabuzard @Tais993 @Taz03
I need some suggestions about a possible problem,

Context:

• A routine (MessageHistoryRoutine) that clears DB records every 24 hrs(no need to hold records past that)
• Purge command that has duration options such as 3hrs, 6 hrs, 12 hrs, 24 hrs.(since we're only storing records upto 24 hrs, max is that)

It become problematic when someone in future adds a new option in PurgeHistoryCommand for 48 hrs or 72 hrs and forgets to reflect that change in routine class that clears every expired record past 24 hrs(so db will never hold anything past 24 hrs).

Point is numbers can change with time and i wanna make sure both the classes are on same page when it comes to this duration limit.

I decided to move constants to a different class Duration, figured it would be neat to add other constants related to duration as well. I'm still not sure if this helps much, Any alternatives or thoughts or perhaps im doing something wrong?

Current:

MessageHistoryRoutine.java

PurgeHistoryCommand.java

Possibly newer changes:

Add Duration.java

MessageHistoryRoutine.java

PurgeHistoryCommand.java

[ankitsmt211]

This feature has reached it's final stage and is now open for reviews.