Add object support in ToggleGen #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashalva
commented
Feb 19, 2024
| get { manager.value(for: ToggleVariables.numericToggle2).numberValue! } | ||
| set { manager.set(.number(newValue), for: ToggleVariables.numericToggle2) } | ||
| } | ||
|
|
||
| public var userDefinedStringToggle: String { | ||
| public var stringToggle2: String { |
There was a problem hiding this comment.
Script automatically changed property names. Not sure why that happened, I guess it was outdated file? @albertodebortoli
There was a problem hiding this comment.
I noticed that too when running it locally yesterday. Yes, I think it was outdated.
| import Foundation | ||
|
|
||
| public struct ToggleVariables { | ||
| public enum ToggleVariables { |
There was a problem hiding this comment.
yep, definitely outdated
| @@ -20,7 +20,7 @@ public struct Object { | |||
|
|
|||
| /// Object description represented as plain json string. | |||
| /// Returns nil if object cant be represented as json string. | |||
| var description: String? { | |||
| public var description: String? { | |||
There was a problem hiding this comment.
I remember efforts to keep this non-public but I guess it's ok (you've used it in the demo app).
There was a problem hiding this comment.
Yes, thats the thing. I could not find any better way to beutify object's presentation. I was using objectValue.map.description but it was showing types as well
albertodebortoli
approved these changes
Feb 19, 2024
|
Nice catch @albertodebortoli, updated 
|
albertodebortoli
approved these changes
Feb 19, 2024
AlexLotsu
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have finalised
objectsupport in Toggles. Now it's time to addobjectsupport inToggleGen.ObjectandObjectSupportedTypeinToggleGenpackage.ToggleGenscript to generate new object properties.Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-19.at.11.11.38.mp4