Fix some printf format specifiers. - #1049
Merged
Merged
Conversation
hugbubby
suggested changes
Aug 8, 2018
hugbubby
left a comment
Member
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1.
Reviewable status: 0 of 1 LGTMs obtained (waiting on @hugbubby)
auto_tests/conference_simple_test.c, line 197 at r1 (raw file):
state1.joined = true; ck_assert_msg(err == TOX_ERR_CONFERENCE_NEW_OK, "failed to create a conference: err = %d", err); fprintf(stderr, "Created conference: id = %u\n", state1.conference);
This is a printf so go ahead and add a period.
iphydf
commented
Aug 9, 2018
iphydf
left a comment
Member
Author
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained (waiting on @hugbubby)
auto_tests/conference_simple_test.c, line 197 at r1 (raw file):
Previously, hugbubby wrote…
This is a printf so go ahead and add a period.
I'd rather not in this PR. That would make it inconsistent with every other printf in this file. Feel free to make a PR to consistently change that in this file.
iphydf
force-pushed
the
printf-types
branch
6 times, most recently
from
August 12, 2018 22:32
a5d99d2 to
32274c4
Compare
hugbubby
approved these changes
Aug 13, 2018
hugbubby
approved these changes
Aug 13, 2018
hugbubby
left a comment
Member
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! 1 of 1 approvals obtained
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is