Skip to content

Fix some printf format specifiers. - #1049

Merged
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:printf-types
Aug 13, 2018
Merged

Fix some printf format specifiers.#1049
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:printf-types

Conversation

@iphydf

@iphydf iphydf commented Aug 4, 2018

Copy link
Copy Markdown
Member

This change is Reviewable

@iphydf iphydf added this to the v0.2.5 milestone Aug 4, 2018
@iphydf iphydf modified the milestones: v0.2.5, v0.2.x Aug 8, 2018

@hugbubby hugbubby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1.
Reviewable status: 0 of 1 LGTMs obtained (waiting on @hugbubby)


auto_tests/conference_simple_test.c, line 197 at r1 (raw file):

        state1.joined = true;
        ck_assert_msg(err == TOX_ERR_CONFERENCE_NEW_OK, "failed to create a conference: err = %d", err);
        fprintf(stderr, "Created conference: id = %u\n", state1.conference);

This is a printf so go ahead and add a period.

@iphydf iphydf left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 LGTMs obtained (waiting on @hugbubby)


auto_tests/conference_simple_test.c, line 197 at r1 (raw file):

Previously, hugbubby wrote…

This is a printf so go ahead and add a period.

I'd rather not in this PR. That would make it inconsistent with every other printf in this file. Feel free to make a PR to consistently change that in this file.

@iphydf
iphydf force-pushed the printf-types branch 6 times, most recently from a5d99d2 to 32274c4 Compare August 12, 2018 22:32

@hugbubby hugbubby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@iphydf
iphydf merged commit a509d25 into TokTok:master Aug 13, 2018
@iphydf
iphydf deleted the printf-types branch August 13, 2018 16:35
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.6 Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants