Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some printf format specifiers. #1049

Merged
merged 1 commit into from
Aug 13, 2018
Merged

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Aug 4, 2018

This change is Reviewable

@iphydf iphydf added this to the v0.2.5 milestone Aug 4, 2018
@iphydf iphydf modified the milestones: v0.2.5, v0.2.x Aug 8, 2018
Copy link
Member

@hugbubby hugbubby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1.
Reviewable status: 0 of 1 LGTMs obtained (waiting on @hugbubby)


auto_tests/conference_simple_test.c, line 197 at r1 (raw file):

        state1.joined = true;
        ck_assert_msg(err == TOX_ERR_CONFERENCE_NEW_OK, "failed to create a conference: err = %d", err);
        fprintf(stderr, "Created conference: id = %u\n", state1.conference);

This is a printf so go ahead and add a period.

Copy link
Member Author

@iphydf iphydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 LGTMs obtained (waiting on @hugbubby)


auto_tests/conference_simple_test.c, line 197 at r1 (raw file):

Previously, hugbubby wrote…

This is a printf so go ahead and add a period.

I'd rather not in this PR. That would make it inconsistent with every other printf in this file. Feel free to make a PR to consistently change that in this file.

@iphydf iphydf force-pushed the printf-types branch 6 times, most recently from a5d99d2 to 32274c4 Compare August 12, 2018 22:32
Copy link
Member

@hugbubby hugbubby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@iphydf iphydf merged commit a509d25 into TokTok:master Aug 13, 2018
@iphydf iphydf deleted the printf-types branch August 13, 2018 16:35
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.6 Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants