Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable local peer discovery #306

Merged
merged 1 commit into from
Dec 15, 2016

Conversation

nurupo
Copy link
Member

@nurupo nurupo commented Dec 8, 2016

#296 was storing local peer discovery option in DHT, when it should be local to friend connections, as friend connections are the only ones who use LAN discovery.


This change is Reviewable

@robinlinden
Copy link
Member

:lgtm_strong:


Reviewed 7 of 7 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@sudden6
Copy link

sudden6 commented Dec 9, 2016

:lgtm_strong:


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@iphydf
Copy link
Member

iphydf commented Dec 10, 2016

:lgtm_strong:


Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


toxcore/Messenger.h, line 80 at r1 (raw file):

    uint16_t tcp_server_port;

    uint8_t hole_punching_enabled;

If you want, you can change this to bool as well. It's an unrelated change, so it's up to you.


Comments from Reviewable

@jhert0
Copy link
Member

jhert0 commented Dec 14, 2016

:lgtm_strong:


Reviewed 7 of 7 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


Comments from Reviewable

@iphydf
Copy link
Member

iphydf commented Dec 15, 2016

@GrayHatter this still needs your review - it is an API change.

@GrayHatter GrayHatter removed their assignment Dec 15, 2016
@iphydf iphydf merged commit 68be338 into TokTok:master Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants