Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a thread-safe version of unix_time and friends. #979

Merged
merged 1 commit into from
Jul 10, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jul 7, 2018

These are not used in a thread-safe way, but it opens the path towards
per-tox-instance time keeping and removal of some unsafe global state.


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Jul 7, 2018
@iphydf iphydf requested a review from zugz July 7, 2018 22:16
@iphydf iphydf force-pushed the mono-time branch 4 times, most recently from a3c423e to d51ec3c Compare July 7, 2018 22:40
@zugz
Copy link

zugz commented Jul 8, 2018 via email

@iphydf
Copy link
Member Author

iphydf commented Jul 8, 2018

No, I meant 980: #980

@zugz
Copy link

zugz commented Jul 8, 2018 via email

@iphydf
Copy link
Member Author

iphydf commented Jul 8, 2018

Ah, I meant 405. Fixed.

@iphydf
Copy link
Member Author

iphydf commented Jul 8, 2018

Thanks for double-checking.

@iphydf iphydf force-pushed the mono-time branch 2 times, most recently from 9c8dc3b to ce7383f Compare July 8, 2018 18:25
Copy link

@sudden6 sudden6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 2 of 2 files at r1.
Reviewable status: 0 of 1 LGTMs obtained (waiting on @zugz)

@iphydf iphydf force-pushed the mono-time branch 4 times, most recently from 8ff0def to fe29fbf Compare July 9, 2018 10:26
These are not used in a thread-safe way, but it opens the path towards
per-tox-instance time keeping and removal of some unsafe global state.
@iphydf iphydf merged commit 4e21c06 into TokTok:master Jul 10, 2018
@iphydf iphydf modified the milestones: v0.2.x, v0.2.4 Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants