Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Check that doc comments match for function decl/defn. #68

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Dec 21, 2021

This currently only works for Doxygen comments, i.e. ones starting with
/**. This is because we can't distinguish between random comments in
the middle of the file and function comments. Ultimately, we'll want all
function comments to be doxygen style comments anyway.


This change is Reviewable

@iphydf iphydf added this to the v0.0.6 milestone Dec 21, 2021
@auto-add-label auto-add-label bot added the enhancement New feature for the user, not a new feature for build script label Dec 21, 2021
Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

This currently only works for Doxygen comments, i.e. ones starting with
`/**`. This is because we can't distinguish between random comments in
the middle of the file and function comments. Ultimately, we'll want all
function comments to be doxygen style comments anyway.
@iphydf iphydf merged commit d6f5345 into TokTok:master Dec 21, 2021
@iphydf iphydf deleted the doc-comments branch December 21, 2021 18:15
@iphydf iphydf modified the milestones: v0.0.6, v0.0.7 Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature for the user, not a new feature for build script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants