Skip to content

Conversation

GrayHatter
Copy link

@GrayHatter GrayHatter commented Jul 11, 2016

@iphydf


This change is Reviewable

@iphydf
Copy link
Member

iphydf commented Jul 11, 2016

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.


README.md, line 4 [r1] (raw file):

***

**Current build status:** [![Build Status](https://travis-ci.org/TokTok/toxcore.svg?branch=master)](https://travis-ci.org/TokTok/toxcore)

Can you also add the coverage status? See https://raw.githubusercontent.com/TokTok/hstox/master/README.md for an example.


Comments from Reviewable

@iphydf
Copy link
Member

iphydf commented Jul 11, 2016

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.


README.md, line 1 [r1] (raw file):

![Project Tox](https://raw.github.com/irungentoo/toxcore/master/other/tox.png "Project Tox")

This could also be changed, in case someone decides to contribute a different logo.


Comments from Reviewable

@GrayHatter
Copy link
Author

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.


README.md, line 1 [r1] (raw file):

Previously, iphydf wrote…

This could also be changed, in case someone decides to contribute a different logo.

Done.

README.md, line 4 [r1] (raw file):

Previously, iphydf wrote…

Can you also add the coverage status? See https://raw.githubusercontent.com/TokTok/hstox/master/README.md for an example.

Done.

Comments from Reviewable

@nurupo
Copy link
Member

nurupo commented Jul 12, 2016

LGTM, unless you want to fix IRC and other links.

@iphydf
Copy link
Member

iphydf commented Jul 12, 2016

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.


README.md, line 5 [r2] (raw file):

**Current build status:** [![Build Status](https://travis-ci.org/TokTok/toxcore.svg?branch=master)](https://travis-ci.org/TokTok/toxcore)
**Current Coverage :** [![Coverage Status](https://coveralls.io/repos/github/TokTok/toxcore/badge.svg?branch=master)](https://coveralls.io/github/TokTok/toxcore?branch=master)

Remove the extra space before ':'


Comments from Reviewable

Requested, suggested
@iphydf
Copy link
Member

iphydf commented Jul 12, 2016

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants