Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JWT authentication #161

Merged
merged 12 commits into from
May 23, 2022
Merged

Add JWT authentication #161

merged 12 commits into from
May 23, 2022

Conversation

OmerShoulstein
Copy link
Collaborator

No description provided.

@OmerShoulstein OmerShoulstein added enhancement New feature or request draft Under constructions labels May 22, 2022
@OmerShoulstein OmerShoulstein added this to the Web Server + API milestone May 22, 2022
@OmerShoulstein OmerShoulstein self-assigned this May 22, 2022
@OmerShoulstein OmerShoulstein linked an issue May 22, 2022 that may be closed by this pull request
Add JWT authentication #154
Closed
Tom-stack3
Tom-stack3 requested changes May 22, 2022
View reviewed changes
web-api/Controllers/ContactsController.cs Outdated Show resolved Hide resolved
web-api/Controllers/ContactsController.cs Outdated Show resolved Hide resolved
@Tom-stack3 Tom-stack3 changed the title Added jwt Add JWT authentication May 22, 2022
@Tom-stack3
Copy link
Collaborator

After Signing up successfully, maybe a JWT token should be created too?

Tom-stack3
Tom-stack3 requested changes May 23, 2022
View reviewed changes
web-api/Controllers/ContactsController.cs Outdated Show resolved Hide resolved
web-api/Controllers/ContactsController.cs Outdated Show resolved Hide resolved
@Tom-stack3 Tom-stack3 self-requested a review May 23, 2022 16:04
Tom-stack3
Tom-stack3 approved these changes May 23, 2022
View reviewed changes
Copy link
Collaborator

@Tom-stack3 Tom-stack3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@TomBenDor TomBenDor removed the draft Under constructions label May 23, 2022
@TomBenDor TomBenDor merged commit 6ab787f into milestone-2 May 23, 2022
@TomBenDor TomBenDor deleted the 154-add-jwt-authentication branch May 23, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tom-stack3 Tom-stack3 Tom-stack3 approved these changes

@TomBenDor TomBenDor TomBenDor approved these changes

Assignees

@OmerShoulstein OmerShoulstein

Labels
enhancement New feature or request
Projects
None yet
Milestone
Web Server + API
Development

Successfully merging this pull request may close these issues.

Add JWT authentication
3 participants
@OmerShoulstein @Tom-stack3 @TomBenDor