Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed React #167

Merged
merged 20 commits into from
May 30, 2022
Merged

Embed React #167

merged 20 commits into from
May 30, 2022

Conversation

TomBenDor
Copy link
Owner

@TomBenDor TomBenDor commented May 29, 2022 •
edited by Tom-stack3
Loading

  • Sign up
  • Timstamp
  • Rendering issues
  • Sending messeges to server using fetch

@TomBenDor TomBenDor added enhancement New feature or request draft Under constructions labels May 29, 2022
@TomBenDor TomBenDor added this to the Web Server + API milestone May 29, 2022
@TomBenDor
Copy link
Owner Author

TomBenDor commented May 29, 2022 •
edited
Loading

many bugs in here

  • timestamp
  • unread
  • last only rendered in the second time
  • signup not working but can if signIn function imported from signin component

@TomBenDor TomBenDor linked an issue May 29, 2022 that may be closed by this pull request
Embed React in Web Server #143
Closed
@Tom-stack3 Tom-stack3 changed the title Embed react Embed React May 29, 2022
Tom-stack3
Tom-stack3 previously approved these changes May 30, 2022
View reviewed changes
Copy link
Collaborator

@Tom-stack3 Tom-stack3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splendid Work!

@Tom-stack3 Tom-stack3 self-requested a review May 30, 2022 10:21
Tom-stack3
Tom-stack3 approved these changes May 30, 2022
View reviewed changes
Copy link
Collaborator

@Tom-stack3 Tom-stack3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's fr

@Tom-stack3 Tom-stack3 enabled auto-merge (squash) May 30, 2022 10:42
@Tom-stack3 Tom-stack3 disabled auto-merge May 30, 2022 10:42
@Tom-stack3 Tom-stack3 enabled auto-merge (squash) May 30, 2022 10:43
@TomBenDor TomBenDor removed the draft Under constructions label May 30, 2022
@Tom-stack3 Tom-stack3 merged commit 0054e76 into milestone-2 May 30, 2022
@Tom-stack3 Tom-stack3 deleted the embed-react branch May 30, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmerShoulstein OmerShoulstein OmerShoulstein approved these changes

@Tom-stack3 Tom-stack3 Tom-stack3 approved these changes

Assignees

@TomBenDor TomBenDor

@Tom-stack3 Tom-stack3

@OmerShoulstein OmerShoulstein

Labels
enhancement New feature or request
Projects
None yet
Milestone
Web Server + API
Development

Successfully merging this pull request may close these issues.

Embed React in Web Server
3 participants
@TomBenDor @Tom-stack3 @OmerShoulstein