Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding contact via API #170

Merged
merged 15 commits into from
May 31, 2022
Merged

Adding contact via API #170

merged 15 commits into from
May 31, 2022

Conversation

OmerShoulstein
Copy link
Collaborator

No description provided.

@OmerShoulstein OmerShoulstein added enhancement New feature or request draft Under constructions labels May 30, 2022
@OmerShoulstein OmerShoulstein added this to the Web Server + API milestone May 30, 2022
@OmerShoulstein OmerShoulstein self-assigned this May 30, 2022
@OmerShoulstein OmerShoulstein linked an issue May 30, 2022 that may be closed by this pull request
Adding Contact extra fields #149
Closed
@TomBenDor TomBenDor changed the title 149 adding contact extra fields Adding contact via API May 30, 2022
@TomBenDor TomBenDor self-requested a review May 30, 2022 18:58
Tom-stack3
Tom-stack3 requested changes May 30, 2022
View reviewed changes
web-client/src/components/ChatPage/ContactsSection.js Outdated Show resolved Hide resolved
web-client/src/components/ChatPage/ContactsSection.js Outdated Show resolved Hide resolved
web-api/Controllers/ContactsController.cs Outdated Show resolved Hide resolved
web-api/Controllers/ContactsController.cs Outdated Show resolved Hide resolved
web-api/Controllers/ContactsController.cs Outdated Show resolved Hide resolved
OmerShoulstein and others added 5 commits May 30, 2022 22:12
@OmerShoulstein @Tom-stack3
Update web-api/Controllers/ContactsController.cs
cedb404 
Co-authored-by: Tommy Zaft <76645845+Tom-stack3@users.noreply.github.com>
@OmerShoulstein @Tom-stack3
Update web-api/Controllers/ContactsController.cs
6ddcb5b 
Co-authored-by: Tommy Zaft <76645845+Tom-stack3@users.noreply.github.com>
@OmerShoulstein @Tom-stack3
Update web-api/Controllers/ContactsController.cs
ffa88ce 
Co-authored-by: Tommy Zaft <76645845+Tom-stack3@users.noreply.github.com>
@OmerShoulstein @TomBenDor
Update web-client/src/components/ChatPage/ContactsSection.js
4a3a584 
Co-authored-by: Tom Ben-Dor <36517134+TomBenDor@users.noreply.github.com>
@OmerShoulstein
Displays display name instead of username
f8312d6
@OmerShoulstein OmerShoulstein requested review from Tom-stack3 and TomBenDor and removed request for TomBenDor May 30, 2022 19:18
TomBenDor
TomBenDor previously approved these changes May 30, 2022
View reviewed changes
Tom-stack3
Tom-stack3 requested changes May 30, 2022
View reviewed changes
Copy link
Collaborator

@Tom-stack3 Tom-stack3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When sending new messages to a newly added contact, the API url should be:
‫‪http://foo.com/api/contacts/<username-of-receiver>/messages‬‬
Currently it's:
‫‪http://foo.com/api/contacts/<chat-id>/messages‬‬
Which is wrong and therefore not working

@Tom-stack3 Tom-stack3 self-requested a review May 30, 2022 20:33
@Tom-stack3 Tom-stack3 requested a review from TomBenDor May 30, 2022 20:34
Tom-stack3
Tom-stack3 approved these changes May 30, 2022
View reviewed changes
Copy link
Collaborator

@Tom-stack3 Tom-stack3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bon travail!

@TomBenDor TomBenDor removed the draft Under constructions label May 31, 2022
@Tom-stack3 Tom-stack3 merged commit b708911 into milestone-2 May 31, 2022
@Tom-stack3 Tom-stack3 deleted the 149-adding-contact-extra-fields branch May 31, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tom-stack3 Tom-stack3 Tom-stack3 approved these changes

@TomBenDor TomBenDor TomBenDor approved these changes

Assignees

@OmerShoulstein OmerShoulstein

Labels
enhancement New feature or request
Projects
None yet
Milestone
Web Server + API
Development

Successfully merging this pull request may close these issues.

Adding Contact extra fields
3 participants
@OmerShoulstein @TomBenDor @Tom-stack3