Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landing Page #26

Merged
merged 29 commits into from
Apr 6, 2022
Merged

Landing Page #26

merged 29 commits into from
Apr 6, 2022

Conversation

OmerShoulstein
Copy link
Collaborator

@OmerShoulstein OmerShoulstein commented Apr 4, 2022 •
edited by Tom-stack3
Loading

Closes #20

@OmerShoulstein OmerShoulstein added this to the Web Client milestone Apr 4, 2022
@Tom-stack3 Tom-stack3 changed the title added join us prompt Added join us prompt Apr 4, 2022
@Tom-stack3 Tom-stack3 self-requested a review April 4, 2022 19:10
@Tom-stack3 Tom-stack3 added the enhancement New feature or request label Apr 4, 2022
@TomBenDor TomBenDor added the ui / ux User interface / User experience improvements label Apr 4, 2022
TomBenDor
TomBenDor requested changes Apr 4, 2022
View reviewed changes
Copy link
Owner

@TomBenDor TomBenDor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bravo.
You may find my remarks awaiting fix.
Have a pleasant week.

web-client/src/App.css Outdated Show resolved Hide resolved
web-client/src/components/PromptPage.js Outdated Show resolved Hide resolved
@TomBenDor TomBenDor changed the title Added join us prompt Landing Page Apr 4, 2022
@TomBenDor TomBenDor added the draft Under constructions label Apr 4, 2022
@TomBenDor
Copy link
Owner

Rebased

@TomBenDor TomBenDor removed the enhancement New feature or request label Apr 5, 2022
TomBenDor
TomBenDor previously requested changes Apr 5, 2022
View reviewed changes
Copy link
Owner

@TomBenDor TomBenDor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • SVG should be responsive.
  • Buttons should have minimum width.
  • It is "MaKore" not "MaKoRe"
  • Instead of .landing-page-name you should just place the logo (png), you may find it in the public folder.

Stunning work,

@TomBenDor
Copy link
Owner

image

It looks even worse on mobile.

Tom-stack3
Tom-stack3 requested changes Apr 5, 2022
View reviewed changes
web-client/src/App.js Outdated Show resolved Hide resolved
web-client/src/components/PromptPage.js Outdated Show resolved Hide resolved
web-client/src/components/PromptPage.js Outdated Show resolved Hide resolved
web-client/src/components/PromptPage.js Outdated Show resolved Hide resolved
web-client/src/components/SignInForm.js Outdated Show resolved Hide resolved
@Tom-stack3
Copy link
Collaborator

The landing page looks stunning!
Just some minor fixes.

@TomBenDor @Tom-stack3
Apply suggestions from code review
b65eba1 
Co-authored-by: Tommy Zaft <76645845+Tom-stack3@users.noreply.github.com>
@Tom-stack3 Tom-stack3 self-requested a review April 5, 2022 21:22
Tom-stack3
Tom-stack3 requested changes Apr 5, 2022
View reviewed changes
Copy link
Collaborator

@Tom-stack3 Tom-stack3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely job!

Tom-stack3
Tom-stack3 previously approved these changes Apr 5, 2022
View reviewed changes
@OmerShoulstein OmerShoulstein requested review from TomBenDor and Tom-stack3 and removed request for Tom-stack3 April 6, 2022 15:47
@TomBenDor TomBenDor removed the draft Under constructions label Apr 6, 2022
TomBenDor
TomBenDor requested changes Apr 6, 2022
View reviewed changes
web-client/src/components/SignUpForm.js Outdated Show resolved Hide resolved
web-client/src/components/SignInForm.js Outdated Show resolved Hide resolved
web-client/src/App.css Outdated Show resolved Hide resolved
web-client/src/App.css Outdated Show resolved Hide resolved
TomBenDor
TomBenDor approved these changes Apr 6, 2022
View reviewed changes
Copy link
Owner

@TomBenDor TomBenDor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow

@TomBenDor TomBenDor enabled auto-merge (squash) April 6, 2022 19:15
@TomBenDor TomBenDor merged commit 5cdf29b into milestone-1 Apr 6, 2022
@TomBenDor TomBenDor deleted the join_prompt branch April 6, 2022 19:17
TomBenDor pushed a commit that referenced this pull request Apr 7, 2022
@OmerShoulstein @TomBenDor
Landing Page (#26)
384f0d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomBenDor TomBenDor TomBenDor approved these changes

@Tom-stack3 Tom-stack3 Awaiting requested review from Tom-stack3

Assignees

@OmerShoulstein OmerShoulstein

Labels
ui / ux User interface / User experience improvements
Projects
None yet
Milestone
Web Client
Development

Successfully merging this pull request may close these issues.

Show promt asking user to Sign up or Sign in
3 participants
@OmerShoulstein @TomBenDor @Tom-stack3