Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live field errors on Sign Up #44

Merged
merged 3 commits into from
Apr 8, 2022

Conversation

Tom-stack3
Copy link
Collaborator

@Tom-stack3 Tom-stack3 commented Apr 7, 2022

Closes #29

@Tom-stack3 Tom-stack3 added ui / ux User interface / User experience improvements priority-2 Essential but not urgent labels Apr 7, 2022
@Tom-stack3 Tom-stack3 added this to the Web Client milestone Apr 7, 2022
@Tom-stack3 Tom-stack3 linked an issue Apr 7, 2022 that may be closed by this pull request
@TomBenDor TomBenDor changed the title Added live field errors Live field errors on Sign Up Apr 8, 2022
Copy link
Owner

@TomBenDor TomBenDor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Username live avaliablity check not supported yet.
  • The moment I type in the username field, the password field shows an error. "Don't yell at me, I'll get there" (Anxious user, 2022).
  • Very cool.

@Tom-stack3
Copy link
Collaborator Author

I think I fixed the issue for the anxious user :)
But I'm not sure it's a good idea to check if a username is available on every change of the field.
It means for every change we will send a query to the server for the specified username, a bit too many requests I suppose.
Therefore I intentionally left it out of the onChange() calls.

@TomBenDor
Copy link
Owner

TomBenDor commented Apr 8, 2022

I think I fixed the issue for the anxious user :)
But I'm not sure it's a good idea to check if a username is available on every change of the field.
It means for every change we will send a query to the server for the specified username, a bit too many requests I suppose.
Therefore I intentionally left it out of the onChange() calls.

You are right. The only solution I can think of is asking the server for availability when the user has not updated the field within like 4 seconds.
Only this is far more complicated so I'll just approve and leave it for you to decide.

Copy link
Owner

@TomBenDor TomBenDor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A work of art

@Tom-stack3 Tom-stack3 enabled auto-merge (squash) April 8, 2022 10:57
@Tom-stack3 Tom-stack3 disabled auto-merge April 8, 2022 10:59
@Tom-stack3 Tom-stack3 merged commit d1b07dc into milestone-1 Apr 8, 2022
@Tom-stack3 Tom-stack3 deleted the 29-live-field-errors-on-sign-up branch April 8, 2022 11:04
@TomBenDor TomBenDor removed the priority-2 Essential but not urgent label Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui / ux User interface / User experience improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Live field errors on Sign Up
2 participants