Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat background image #64

Merged
merged 3 commits into from
Apr 14, 2022
Merged

Chat background image #64

merged 3 commits into from
Apr 14, 2022

Conversation

TomBenDor
Copy link
Owner

No description provided.

@TomBenDor TomBenDor added the draft Under constructions label Apr 13, 2022
@TomBenDor TomBenDor added this to the Web Client milestone Apr 13, 2022
@TomBenDor TomBenDor added the ui / ux User interface / User experience improvements label Apr 13, 2022
@TomBenDor TomBenDor enabled auto-merge (squash) April 13, 2022 20:05
@TomBenDor TomBenDor added draft Under constructions and removed draft Under constructions labels Apr 13, 2022
OmerShoulstein
OmerShoulstein requested changes Apr 14, 2022
View reviewed changes
Copy link
Collaborator

@OmerShoulstein OmerShoulstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
We should use css variables instead of hard coding the background color.

@TomBenDor TomBenDor removed the draft Under constructions label Apr 14, 2022
@TomBenDor TomBenDor merged commit 86b7d10 into milestone-1 Apr 14, 2022
@TomBenDor TomBenDor deleted the background-image branch April 14, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmerShoulstein OmerShoulstein OmerShoulstein approved these changes

Assignees
No one assigned
Labels
ui / ux User interface / User experience improvements
Projects
None yet
Milestone
Web Client
Development

Successfully merging this pull request may close these issues.
2 participants
@TomBenDor @OmerShoulstein