Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat welcome message #67

Merged
merged 5 commits into from
Apr 14, 2022
Merged

Chat welcome message #67

merged 5 commits into from
Apr 14, 2022

Conversation

TomBenDor
Copy link
Owner

When user signs in, he \ she firsts sees a message asking to choose user.

@TomBenDor TomBenDor added ui / ux User interface / User experience improvements draft Under constructions labels Apr 14, 2022
@TomBenDor TomBenDor added this to the Web Client milestone Apr 14, 2022
@TomBenDor TomBenDor linked an issue Apr 14, 2022 that may be closed by this pull request
Chat welcome message #58
Closed
@Tom-stack3
Copy link
Collaborator

Maybe we should rename currentContact to currentContactId or something similar?
The original name might be confusing and suggest that the actual contact object is stored in it.
I gotta admit that I fell for it :(

Tom-stack3
Tom-stack3 approved these changes Apr 14, 2022
View reviewed changes
Copy link
Collaborator

@Tom-stack3 Tom-stack3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spectacular job!

OmerShoulstein
OmerShoulstein approved these changes Apr 14, 2022
View reviewed changes
Copy link
Collaborator

@OmerShoulstein OmerShoulstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the best pull requests I have ever seen, keep up the good work!

@TomBenDor TomBenDor removed the draft Under constructions label Apr 14, 2022
@TomBenDor TomBenDor merged commit ee65a87 into milestone-1 Apr 14, 2022
@TomBenDor TomBenDor deleted the chat-welcome-message branch April 14, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmerShoulstein OmerShoulstein OmerShoulstein approved these changes

@Tom-stack3 Tom-stack3 Tom-stack3 approved these changes

Assignees
No one assigned
Labels
ui / ux User interface / User experience improvements
Projects
None yet
Milestone
Web Client
Development

Successfully merging this pull request may close these issues.

Chat welcome message
3 participants
@TomBenDor @Tom-stack3 @OmerShoulstein