Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile picture in chat page #71

Merged
merged 5 commits into from
Apr 15, 2022
Merged

Profile picture in chat page #71

merged 5 commits into from
Apr 15, 2022

Conversation

OmerShoulstein
Copy link
Collaborator

No description provided.

@OmerShoulstein OmerShoulstein added enhancement New feature or request draft Under constructions labels Apr 14, 2022
@OmerShoulstein OmerShoulstein added this to the Web Client milestone Apr 14, 2022
@OmerShoulstein OmerShoulstein linked an issue Apr 14, 2022 that may be closed by this pull request
Embeding profile pictures in ChatPage #63
Closed
TomBenDor
TomBenDor previously requested changes Apr 14, 2022
View reviewed changes
Copy link
Owner

@TomBenDor TomBenDor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's simply not working.

@TomBenDor TomBenDor self-requested a review April 15, 2022 08:01
TomBenDor
TomBenDor approved these changes Apr 15, 2022
View reviewed changes
Copy link
Owner

@TomBenDor TomBenDor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those even bears?

Tom-stack3
Tom-stack3 approved these changes Apr 15, 2022
View reviewed changes
Copy link
Collaborator

@Tom-stack3 Tom-stack3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stupendous job!

@OmerShoulstein OmerShoulstein removed the draft Under constructions label Apr 15, 2022
@OmerShoulstein OmerShoulstein enabled auto-merge (squash) April 15, 2022 08:52
@OmerShoulstein OmerShoulstein merged commit 1772bf5 into milestone-1 Apr 15, 2022
@OmerShoulstein OmerShoulstein deleted the 63-embeding-profile-pictures-in-chatpage branch April 15, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tom-stack3 Tom-stack3 Tom-stack3 approved these changes

@TomBenDor TomBenDor TomBenDor approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Web Client
Development

Successfully merging this pull request may close these issues.

Embeding profile pictures in ChatPage
3 participants
@OmerShoulstein @TomBenDor @Tom-stack3