Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters are lost when container list changes #85

Closed
rocketraman opened this issue May 14, 2016 · 6 comments
Closed

Filters are lost when container list changes #85

rocketraman opened this issue May 14, 2016 · 6 comments
Assignees
Milestone

Comments

@rocketraman
Copy link

When I have a filter s=r set in sen, when the container list changes while on a different tab e.g. a container details tab, the filter is still set but the list is no longer filtered.

I am running the dev version, but this is an issue on the stable version as well.

@TomasTomecek
Copy link
Owner

I also experienced that filters are a bit clunky when mixed with other operations but didn't have a chance to open an issue, so thanks for doing so!

Right now I'm in process of significant rewrite of command system. Once that's done, I'll take a look in this.

@TomasTomecek TomasTomecek added this to the 0.4.0 milestone May 24, 2016
@TomasTomecek TomasTomecek self-assigned this May 28, 2016
TomasTomecek added a commit that referenced this issue May 28, 2016
also move it to views

Related #85
@TomasTomecek
Copy link
Owner

this should be fixed in master now (had to rewrite it much); haven't tested extensively, will close this once 0.4 is out

@rocketraman
Copy link
Author

this should be fixed in master now (had to rewrite it much); haven't tested extensively, will close this once 0.4 is out

It's definitely better. The filter now stays active. However, now I am seeing the filtered list does not update when the list of containers changes e.g. a container is stopped and a new one started with an updated image. The filtered list just keeps the old container listed. I do have the container open in a "detail" tab -- not sure if that makes a difference.

@TomasTomecek
Copy link
Owner

looks like that filtering needs even more care; before doing final release, I'll take care of this

TomasTomecek added a commit that referenced this issue Jun 15, 2016
@TomasTomecek
Copy link
Owner

Found it, finally! If an image had multiple names, only the first one was taken into account. So now, all names are being considered.

Could you please retest with master? If it doesn't work, I would appreciate detailed steps to reproduce since this is getting pretty complex.

I tested like this: I applied filter asdqwe. In other terminal I kept creating/removing containers with name asdqwe and I kept tagging and untagging an image with name asdqwe. The interface was being continuously updated and only correct objects were displayed.

@TomasTomecek
Copy link
Owner

This should be fixed in 0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants