-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Utility Delegates #179
Open
nbness2
wants to merge
13
commits into
Tomm0017:master
Choose a base branch
from
nbness2:enhancement/Delegates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows you to delegate a `Pawn` extension property to an `AttributeKey` for easy get/set. This is meant to reduce or potentially remove the possibility of bugs related to repeating code.
This may be a problem if you worry about getting something that isn't a `T`, but you can set a default value (thus delegating to an `AttributeDelegate` instead) using the invoke operator `()`. Example: `val Pawn.isSmart by IS_SMART_ATTRIBUTE(defaultValue = true)`
`VarpDelegate` allows you to delegate a `Player` extension property to this to allow for easy getting and setting as well as intermediate translating if needed
An example usage of `IntVarp`: `var Player.questPoints by IntVarp(101) // 101 is the varp for Quest Points` Now you can `Player.questPoints += 25` or `Player.questPoints = -200`
`VarbitDelegate` allows you to easily get and set the value of a varbit and have intermediate translations if necessary
Example usage: `val Player.slayerPoints by IntVarbit(4068) // 4068 is the varbit id for slayer points`
Example usage: `val Player.gargoyleSlayer by BoolVarbit(4027) // 4027 is the varbit id for Gargoyle Slayer unlock`
[576657d] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done?
AttributeKey<T>
as a delegate for aPawn
extension property returningT
. Example:var Player.protectItem by PROTECT_ITEM_ATTR
-- You can operator invoke the
AttributeKey<T>
with aT
value to return anAttributeDelegate<T>
with a default value that you passed. Example:var Player.protectItem by PROTECT_ITEM_ATTR(false)
T
delegate for aPlayer
extension property returningT
.--
IntVarp
is included as a sample implementation ofVarpDelegate
. Example:var Player.questPoints by IntVarp(101)
T
delegate for aPlayer
extension property returningT
.--
IntVarbit
is included as a sample implementation ofVarbitDelegate
. Example:var Player.slayerPoints by IntVarbit(4068)
--
BoolVarbit
is included as a sample implementation ofVarbitDelegate
. Example:var Player.gargoyleSlayer by BoolVarbit(4027)