Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Gibbs sampler back to sequential #53

Merged
merged 3 commits into from
Jul 14, 2021
Merged

Conversation

TommyJones
Copy link
Owner

Doing this b/c (a) doing parallel sampling in a way that respects the user's seed and conforms to CRAN policies was more trouble than it was worth because (b) parallel sampling (which was "approximate Gibbs" a-la Newman et al., 2009) significantly decreased goodness of fit by several metrics I usually rely on.

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #53 (270cd08) into main (047ba67) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 270cd08 differs from pull request most recent head 265d950. Consider uploading reports for the commit 265d950 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   95.07%   95.13%   +0.06%     
==========================================
  Files          11       11              
  Lines        1117     1111       -6     
==========================================
- Hits         1062     1057       -5     
+ Misses         55       54       -1     
Impacted Files Coverage Δ
R/utils.R 90.54% <100.00%> (+0.39%) ⬆️
src/lda_gibbs2.cpp 98.69% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 047ba67...265d950. Read the comment docs.

@TommyJones TommyJones merged commit c39c005 into main Jul 14, 2021
@TommyJones TommyJones deleted the sequential-gibbs branch July 14, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant