Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FGP_TV: Change default non negativity to False #1826

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

MargaretDuff
Copy link
Member

@MargaretDuff MargaretDuff commented Jun 10, 2024

Related issues/links

Closes #1825

Checklist

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have updated the relevant documentation
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License
  • I confirm that the contribution does not violate any intellectual property rights of third parties

--->

@MargaretDuff MargaretDuff changed the title FGP_TV: Change default non negativitiy to False FGP_TV: Change default non negativity to False Jun 10, 2024
Copy link
Contributor

@jakobsj jakobsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MargaretDuff for processing this so quickly! New time record from issue creation to PR? :)

Added a note to say default version has changed

Signed-off-by: Margaret Duff <43645617+MargaretDuff@users.noreply.github.com>
Signed-off-by: Margaret Duff <43645617+MargaretDuff@users.noreply.github.com>
@MargaretDuff
Copy link
Member Author

MargaretDuff commented Jun 12, 2024

image

@MargaretDuff MargaretDuff merged commit c2c2c17 into TomographicImaging:master Jun 12, 2024
8 checks passed
@MargaretDuff MargaretDuff deleted the fgp_tv_neg branch June 12, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FGP_TV nonnegativity to be changed from True to False
3 participants