Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change registration tab name #241

Merged
merged 12 commits into from
May 24, 2024
11 changes: 6 additions & 5 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
# ChangeLog

## vx.x.x
* Add automatic registration functionality
* Set empty pop-up menus for the main windows
* Set Tabified widgets not to move or close
* Set QDockWidgets flag to NoDockWidgetFeatures to prevent them being moved or lost
* Consume events 'w' and 's' in viewers to avoid render changes between wireframe and surface respectively
* Edit registration-tab name from "Manual" to "Initial" #241
* Add automatic registration functionality #304
* Set empty pop-up menus for the main windows #217
* Set Tabified widgets not to move or close #226 #217
* Set QDockWidgets flag to NoDockWidgetFeatures to prevent them being moved or lost #226 #217
* Consume events 'w' and 's' in viewers to avoid render changes between wireframe and surface respectively #218
* Added argument parser to idvc command. This allows the user to specify the debugging level
* Add workaround for box clipping due to VTK behaviour change from 9.1. Removed requirement for VTK 8.1.2
* add build directory to gitignore
Expand Down
6 changes: 3 additions & 3 deletions src/idvc/dvc_interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -1042,7 +1042,7 @@ def setup3DPointCloudPipeline(self):
def CreateRegistrationPanel(self):
"""Create the Registration Dockable Widget"""

self.registration_panel = generateUIDockParameters(self, '2 - Manual Registration')
self.registration_panel = generateUIDockParameters(self, '2 - Initial Registration')
dockWidget = self.registration_panel[0]
dockWidget.setObjectName("RegistrationPanel")
groupBox = self.registration_panel[5]
Expand Down Expand Up @@ -1739,7 +1739,7 @@ def LoadCorrImageForReg(self,resample_corr_image= False, crop_corr_image = False
crop_image=crop_corr_image, origin=origin, target_z_extent=z_extent, finish_fn=self.completeRegistration, output_dir=os.path.abspath(tempfile.tempdir))

def completeRegistration(self):
"""It shows the registration difference volume in the viewer and sets up the tab for the manual registration.
"""It shows the registration difference volume in the viewer and sets up the tab for the registration.
It runs the automatic registration and shows the results and the extra buttons."""
self.manualRegistration()
automatic_reg_worker = Worker(self.automatic_reg_run)
Expand Down Expand Up @@ -1937,7 +1937,7 @@ def reg_viewer_update(self, type = None):
type : str
If 'starting registration' then the registration viewer is centred on the slice that contains point 0.
This is the case if the "Start Registration" button is pressed. Otherwise, when type=None we are in the middle of
manual registration and the viewer is centred on the current slice
registration and the viewer is centred on the current slice
If 'manual registration' then the translation widgets are updated with the current translation on each axis.
If 'automatic registration' then the translation widgets are not updated.
'''
Expand Down