Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally include cookies and requests in JSON #5

Merged
merged 1 commit into from Mar 4, 2016

Conversation

@andersju
Copy link
Contributor

@andersju andersju commented Feb 17, 2016

I've found PhearJS to be immensely useful for a project I'm working on, but I also needed it to return all cookies (including ones set by JS) and all HTTP requests generated by a page. Not sure if it's out of scope for this project, but this makes it possible with two new parameters, get_requests and get_cookies, both false by default.

Very simple change, with the disclaimer that I'm certainly no JS/CoffeeScript wiz (and I'm new to PhantomJS), but it's been working well for me.

@Tomtomgo
Copy link
Owner

@Tomtomgo Tomtomgo commented Feb 18, 2016

@andersju thanks a lot! Seems like a useful addition. I will take a good look at it soon.

@Tomtomgo Tomtomgo merged commit 7523411 into Tomtomgo:master Mar 4, 2016
@Tomtomgo
Copy link
Owner

@Tomtomgo Tomtomgo commented Mar 4, 2016

Merged this one, thanks a lot @andersju 👍 💯

@thomasmodeneis
Copy link

@thomasmodeneis thomasmodeneis commented Mar 4, 2016

Sorry mate, I implemented this in my fork and forgot to come back here.
I will test this implementation later on, thanks for this :)
Cheers

@andersju
Copy link
Contributor Author

@andersju andersju commented Mar 4, 2016

@Tomtomgo: Sweet! And thanks for your work!

@andersju andersju deleted the andersju:return-cookies-and-requests branch Mar 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants