Optionally include cookies and requests in JSON #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@andersju thanks a lot! Seems like a useful addition. I will take a good look at it soon. |
Owner
|
Merged this one, thanks a lot @andersju 👍 💯 |
|
Sorry mate, I implemented this in my fork and forgot to come back here. |
Contributor
Author
|
@Tomtomgo: Sweet! And thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found PhearJS to be immensely useful for a project I'm working on, but I also needed it to return all cookies (including ones set by JS) and all HTTP requests generated by a page. Not sure if it's out of scope for this project, but this makes it possible with two new parameters, get_requests and get_cookies, both false by default.
Very simple change, with the disclaimer that I'm certainly no JS/CoffeeScript wiz (and I'm new to PhantomJS), but it's been working well for me.