Add compability for IsaacGym Preview 4 #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since IsaacGym Preview 4, IsaacGymenvs requires three additional parameters. Two (rl_device and force_render) of these wherer already present in the configuration file read by hydra. The last one, virtual_screen_capture, is now passed through and appended to the config. Lastly, the OmegaConfs are also predefined by the newest version. Thus, they are now replaced to keep backwards compability. An alternative would be to try setting them and catch the error. However, best practice would be trying each one seperatly.
|
Already implemented in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since IsaacGym Preview 4, IsaacGymEnvs requires three additional parameters.
Two (
rl_deviceandforce_render) of these where already present in the configuration file read by hydra.The last one,
virtual_screen_capture, is now passed through and appended to the config.Lastly, the OmegaConfs are also predefined by the newest version.
Thus, they are now replaced to keep backwards compatibility.
An alternative would be to try setting them and catch the error.
However, best practice would be trying each one separately.