Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE, refactor code, bump version kotlin and dependencies #4

Merged
merged 2 commits into from
Aug 17, 2017
Merged

Fix NPE, refactor code, bump version kotlin and dependencies #4

merged 2 commits into from
Aug 17, 2017

Conversation

ldhnam
Copy link
Contributor

@ldhnam ldhnam commented Aug 17, 2017 •
edited
Loading

Fix NPE
Refactor code
Bump version kotlin, dependencies

@ldhnam ldhnam changed the title Fix NPE, refactor code Fix NPE, refactor code, bump version kotlin and dependencies Aug 17, 2017
@TonnyL TonnyL merged commit 5288812 into TonnyL:master Aug 17, 2017
@TonnyL
Copy link
Owner

TonnyL commented Aug 17, 2017

Merged. But in the OnOptioinsMenuItemSelected() func, it is better to use if else rather than when(switch in java) .

@ldhnam
Copy link
Contributor Author

ldhnam commented Aug 17, 2017

@TonnyL thank you, I got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ldhnam @TonnyL