Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix allowColumnReordering: true not working while allowRowReordering is false #515

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Fix allowColumnReordering: true not working while allowRowReordering is false #515

merged 1 commit into from
Mar 10, 2023

Conversation

HitomiTenshi
Copy link
Contributor

Fixes issue #514.

@ndrsn ndrsn merged commit 052f07e into TonyGermaneri:master Mar 10, 2023
@ndrsn
Copy link
Collaborator

ndrsn commented Mar 10, 2023

Apologies for the enormous delay in getting merged, @HitomiTenshi — this completely slipped through the radar. Thanks for your PR!

@HitomiTenshi HitomiTenshi mentioned this pull request Mar 10, 2023
Open
ndrsn added a commit that referenced this pull request Apr 3, 2023
@ndrsn
Revert "Fix allowColumnReordering not working while allowRowReorderin…
ce0f664 
…g is false (#515)"

This reverts commit 052f07e.

It causes a bug when clicking the column header to sort: the
self.currentCell.context will be set to '-webkit-grab' instead of 'cell',
thereby disabling normal function of the click handler (see line 861 of
events/index.js).
@ndrsn
Copy link
Collaborator

ndrsn commented Apr 3, 2023

Embarrassingly enough, I had to revert this change (see commit message). Will work on a fix.

@ndrsn ndrsn mentioned this pull request Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangxingliu hangxingliu hangxingliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HitomiTenshi @ndrsn @hangxingliu