Replace TimerTask with ScheduledExecutorService #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 18, 2019 15:53
marci4
requested changes
Apr 14, 2019
| @@ -0,0 +1,47 @@ | |||
| /* | |||
There was a problem hiding this comment.
Could you please use the license provided in https://github.com/TooTallNate/Java-WebSocket/blob/master/LICENSE
|
Ready for re-review |
marci4
approved these changes
Apr 15, 2019
marci4
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By getting rid of TimerTask, we remove an assumption that the system clock will not be modified.
Related Issue
Fixes #869
How Has This Been Tested?
Observed that there is no longer an issue when the system time is changed.
Types of changes
Checklist: