Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle filenames with 'file://' shema, in getFileName method #40

Closed
wants to merge 1 commit into from
Closed

Handle filenames with 'file://' shema, in getFileName method #40

wants to merge 1 commit into from

Conversation

mathiasjakobsen
Copy link
Contributor

Will fix bindings for use with Electron.

Fixes #29

@E3V3A
Copy link

E3V3A commented Apr 13, 2018

@TooTallNate Please merge!

@cinan
Copy link

cinan commented Jul 5, 2018

+1

@ViliusSutkus89
Copy link
Contributor

@mathiasjakobsen Thanks for the patch, solved one of my problems.
However I ran into another one. fileName being file schema encoded means all the special characters are encoded too. Including spaces. C:/Program%20Files/
Ended up using "file-uri-to-path" module
ViliusSutkus89@3953f2a

@TooTallNate
Copy link
Owner

Thanks @mathiasjakobsen and @ViliusSutkus, I've merged your changes in d0bd6f8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getFileName does not work in electron
5 participants