Uses actual error code to detect resolution exceptions #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two following codes are used when a resolution fails.
MODULE_NOT_FOUNDis used by the Node resolution when it fails for any reasonQUALIFIED_PATH_RESOLUTION_FAILEDis thrown by PnP when an unqualified path cannot be successfully resolved to a qualified path (ie when the resolver cannot find a file that map to the specified absolute request even after tryingindex.js/index.node/ etc alternatives).I removed the previous check as I think
MODULE_NOT_FOUNDis quite old (even Node 4 has it), but I can add it back if you think that makes sense.